[wp-trac] [WordPress Trac] #23120: There should be indication that widget settings have been saved
WordPress Trac
noreply at wordpress.org
Thu Mar 14 13:32:42 UTC 2013
#23120: There should be indication that widget settings have been saved
----------------------------------------------+------------------
Reporter: jacopo.vip | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.6
Component: Widgets | Version: 3.5
Severity: normal | Resolution:
Keywords: ui-focus has-patch needs-testing |
----------------------------------------------+------------------
Comment (by adamsilverstein):
thanks for the review. my original patch referenced the existing yes.png
and no.png files in wp-includes/images. the new images from @cdog are the
retina versions and upon review look very similar to the original
versions.
the sprite images you referenced are b&w, is that preferable to the color
icons we are using now? it seems like green check and red x include color
to help make the action clearer, but if they don't match the rest of the
interface b&w might make more sense.
if the images are already in wp-includes/images it seems like we can
reference them directly? or is there a reason to copy them over to wp-
admin instead of in wp-includes? i can rework the css to use the
appropriate images, just let me know what you think is best!
Replying to [comment:16 helen]:
> NB: Not actually testing the patch just yet.
>
> Those yes/no icons are ugly, don't match the admin, and make me super
sad. We've got way better ones in the `wp-includes/images/uploader-
icons*.png` sprite, although you can't go guessing at where those are
located so we'd need to copy them (or put a version of them) into `wp-
admin/images`. If the coloring doesn't seem right, JerrySarcastic should
be able to help us there, as he created those icons, or anybody handy with
the source, which is located in the design repo:
http://design.svn.wordpress.org/production/wp-includes/images/
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23120#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list