[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 thanks for the feedback, question: when you say

 The "by (author name)" part in the meta box is redundant:

 do you mean the line at the bottom that shows the restore event meta info?
 this shows who took the action of restoring the revision, not the author
 of the revision itself. maybe change language will make that clearer? its
 supposed to show you - who did the restore, because it might not be you!

 since we do want to change the display of author info in the revision meta
 box, i changed the wp_post_revision_title function; however if these
 changes are going to break something else i could instead provide a new,
 differently named & updated function. or are the changes minor enough to
 be acceptable, but just need documenting?

 Replying to [comment:82 SergeyBiryukov]:
 > I guess it's worth noting that `wp_post_revision_title()` got a
 backward-incompatible change in [23506].
 >
 > Previously, it used to return the revision date and time: [[BR]]
 > http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/post-
 template.php#L1294
 >
 > Now it returns the revision author name first: [[BR]]
 > http://core.trac.wordpress.org/browser/trunk/wp-includes/post-
 template.php?rev=23653#L1319
 >
 > This creates three issues:
 > 1. The strings in `edit-form-advanced.php` still expect date and time
 first: [[BR]]
 >  http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-
 advanced.php?rev=23683#L39
 >  Changing "from" to "by" and updating the translator comment would
 probably be enough.
 > 2. The "by (author name)" part in the meta box is redundant:
 [attachment:23497.revisions-meta-box.png].
 > 3. `wp_post_revision_title()` inline description should be updated.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:85>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software