[wp-trac] [WordPress Trac] #19570: Post Formats: admin UI + fallbacks for themes that don't support them

[WordPress Trac]

#19570: Post Formats: admin UI + fallbacks for themes that don't support them
----------------------------+------------------
 Reporter:  alexkingorg     |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.6
Component:  Post Formats    |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |
----------------------------+------------------

Comment (by helen):

 Replying to [comment:83 aaroncampbell]:
 > I was testing this out on my personal site and noticed that the UI for
 choosing an image for an image post format is missing the filter dropdown
 (usually offers "images" and "Uploaded to this post").

 There's quite a bit missing for that modal - filter, current selection,
 and insert from URL.

 Replying to [comment:84 ryelle]:
 > Also, I don't really think this patch should be removing the .nav-tab
 CSS, at least, not without some replacement - it's still used on
 Manage/Install themes, at least.

 Correct. Please do not alter any admin CSS that is not specific to post
 formats - I reused some existing classes just to get a first run in, so we
 should not be altering existing CSS like that for `.nav-tab`.

 Other notes on the patch:
 * `var currentPostFormat = '<?php echo esc_html( $active_post_type_slug );
 ?>'` - should be using `wp_localize_script()` for that.
 * Hex values should use shorthand where possible.
 * `#titlediv #title` is an input and therefore should not use a pixel
 height, and actually, see #23189.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19570#comment:85>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software