[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

WordPress Trac noreply at wordpress.org
Tue Mar 12 00:45:30 UTC 2013


#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 Replying to [comment:77 adamsilverstein]:
 > Replying to [comment:76 MikeHansenMe]:
 > > @adamsilverstein I am still seeing strange things after applying patch
 21. I have 3 revisions "first" "second" and "third" now when I view
 compare revision page I cannot see "third" at all I would expect to see
 this when on the most recent revision. Showing "Second" was removed and
 "third" was added. Currently I cannot see that. I am going to do some more
 testing to see if I can find other quirks with the patch. Thanks for
 providing updated patches.
 >
 >
 > thanks for pointing that out. still fine tuning, will have more updates
 in a bit.
 >
 > currently core does not store a revision that matches the current state
 of the post in the database.  (addressed in #16215). i was fudging this in
 my earlier code by inserting a copy of the current post, will look at that
 again cause we'll need it till the first post update when the data is
 corrected.

 on second thought - i don't think we want to show the current revision in
 the one handle slider - what would happen if you hit the restore button
 (nothing)? i guess i could hide the restore button in the that handle
 position, would that make sense?

 in my latest code you do see the current post data, but only in the
 compare two handle mode - where you want to compare a previous revision to
 another revision, possibly the current version.  you can't restore to the
 current revision, because restore always restores the right handle.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:78>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list