[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

WordPress Trac noreply at wordpress.org
Fri Mar 8 22:14:49 UTC 2013


#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 thanks for testing. a few notes:

  * the direction is reversed in the (next) patch, that may make more
 sense. in the new setup, the oldest revisions are on the left, the newest
 ones on the right.  i will post that patch when i have everything else
 addressed, you might want to test again after that...
  * did you do this test using the latest trunk? the code was updated
 recently and some of this sounds like buggy behavior that was fixed,
 please try with latest updates to see if you still have the issues; i was
 not able to reproduce the bug you described creating a new post and
 revising it --  the revisions screen worked as expected (although with the
 direction reversed)
  * the 'compare two revisions' should not be available if there are fewer
 than three revisions

 here is a screen recording of my test trying to reproduce the error you
 outline: http://cl.ly/NQb0

 again, appreciate the testing & feedback.

 Replying to [comment:59 MikeHansenMe]:
 > I have not been following this feature closely but wanted to leave some
 thoughts from my recent testing. After testing I did read some of the
 comments on this page which explained the most recent version is on left
 and oldest on right side of slider. This seems backwards because below you
 show what was removed(old version) on the left and what was added on the
 right(new version). I know a lot of work has gone in already just wanted
 to voice some concerns. Here are some steps and thoughts I had testing.
 >
 > - Create Page
 > - Add content "Original Content"
 > - Update content "Revision 1"
 > - Under Screen Options check revisions
 > - Click the bottom revision link
 > - Page opens, note the sliders handle to the left
 > - Slide it to the right "Comparing current version to revision 2 of 2"
 (nothing shown.. confused now "What is the purpose of the slider at this
 point...")
 > - Slide it back to the left
 > - Compare two revisions checkbox
 > - Slide middle handle to the right (result: same as 7 )
 > - Slide left handle to middle (left shows nothing, right shows "Original
 Content")
 > - Unclick Compare two revisions check box
 > - Slide from right to left ("Wait... Original content is on right and
 revision 1 is on left...")
 > - confused again or still..
 > - Move slider back to right side
 > - click compare two revisions again
 > - Slide the right slider to middle and uncheck Compare two revisions
 (Cannot compare revision to itself.... Confused again)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:60>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list