[wp-trac] [WordPress Trac] #20328: get_date_from_gmt assumes current gmt_offset is appropriate

[WordPress Trac]

#20328: get_date_from_gmt assumes current gmt_offset is appropriate
---------------------------+------------------------------
 Reporter:  scottconnerly  |       Owner:  nacin
     Type:  defect (bug)   |      Status:  closed
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Date/Time      |     Version:
 Severity:  normal         |  Resolution:  fixed
 Keywords:  has-patch      |
---------------------------+------------------------------
Changes (by nacin):

 * owner:   => nacin
 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"23618"]:
 {{{
 #!CommitTicketReference repository="" revision="23618"
 Properly handle timezones in get_date_from_gmt() rather than relying on
 the implicit gmt_offset. This offset is only good for the current time,
 rather than the passed time, which causes problems when converting a DST
 date when DST is not in effect, or vice versa.

 Update get_gmt_from_date() to make these functions match in formatting, as
 they are complementary and just reverse a few operations.

 props scholesmafia
 Tests: [1233/tests]

 fixes #20328.
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20328#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software