[wp-trac] [WordPress Trac] #23649: Twenty Thirteen: Show portrait images correctly in gallery post formats

[WordPress Trac]

#23649: Twenty Thirteen: Show portrait images correctly in gallery post formats
---------------------------+--------------------
 Reporter:  obenland       |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  3.6
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+--------------------

Comment (by obenland):

 Replying to [comment:2 lancewillett]:
 >  1. {{{max-height: 1000%}}} looks unintentional :)

 It just needs to be set to a value where the image covers the whole width
 of the thumbnail. Or removed, which I will do in the next patch.

 [[BR]]

 >  2. For {{{twentythirteen_get_attachment_link}}} no other way to get
 that information from core and avoid this extra code? It'd be cool if core
 output the orientation for *all* themes to take advantage of it.

 I'm not sure. `wp_get_attachment_link()` is a generic function that
 returns links to all attachment types, not only images. We could make that
 check in `gallery_caption()` and add a class to the icon tag. But I'm not
 sure it'll find its way into core in time.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23649#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software