[wp-trac] [WordPress Trac] #23674: Twenty Eleven: twentyeleven_url_grabber() should not be pluggable

WordPress Trac noreply at wordpress.org
Sun Mar 3 04:08:00 UTC 2013


#23674: Twenty Eleven: twentyeleven_url_grabber() should not be pluggable
-------------------+---------------------------
 Reporter:  nacin  |       Type:  defect (bug)
   Status:  new    |   Priority:  normal
Milestone:  3.6    |  Component:  Bundled Theme
  Version:  trunk  |   Severity:  normal
 Keywords:         |
-------------------+---------------------------
 Looking at [23474]. In the past, we've had two types of functions for
 default themes:

  A. It's a function that gets used in a theme. Should be pluggable.

  B. It's a function that gets used as a hook callback. No need to be
 pluggable.

 However, twentyeleven_url_grabber() is a utility function. It wasn't an
 oversight, rather, I don't think there is a valid reason for it to be
 pluggable. Any change in the regular expression could expose a security
 vulnerability. A function to extract items from content could certainly
 make for a good core function, and there are tickets for that. But
 allowing this function to be pluggable doesn't help much.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23674>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list