[wp-trac] [WordPress Trac] #23658: wp_deregister_script('jquery') and wp_enqueue('jquery-ui-dialog') dependancy Issue

WordPress Trac noreply at wordpress.org
Sat Mar 2 11:41:14 UTC 2013


#23658: wp_deregister_script('jquery') and wp_enqueue('jquery-ui-dialog')
dependancy Issue
--------------------------------+------------------------------
 Reporter:  eliddon             |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  External Libraries  |     Version:  3.5.1
 Severity:  normal              |  Resolution:
 Keywords:  reporter-feedback   |
--------------------------------+------------------------------

Comment (by TobiasBg):

 As a side note:

 Please don't ship a custom version of jQuery in your theme (as you are in
 the else branch of your code). This is bound to break other plugins and
 create unnecessary support requests for other developers, if people don't
 update your theme. There's no need to ship such a custom version, just use
 the version that ships with jQuery.

 I can understand that loading jQuery from a CDN can be beneficial, but in
 your case it won't make much of a difference, as you are loading many
 other JS files anyway. Also note that your check for whether the Google
 CDN is reachable every five minutes is not that useful: You are checking
 whether your server can reach the Google CDN, which will not guarantee
 that the visitor of your site can reach the Google CDN via his internet
 connection.

 Please also make sure that you are (if at all) only load another version
 on the frontend, so that you don't break the admin area.

 So, in short: Just ditch that code and your problems will be solved.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23658#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list