[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
---------------------------------------+------------------------
 Reporter:  adamsilverstein            |       Owner:  westi
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  3.6
Component:  Revisions                  |     Version:  3.5.1
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch needs-testing  |
---------------------------------------+------------------------

Comment (by adamsilverstein):

 that clearing break was a leftover from my options mockup (now removed) -
 will remove it in my next patch.

 i had the same concern about the restore button, it always restores the
 right hand revision, but thats not obvious. thought about two retore
 buttons (left/right) but i think your idea is best, will try this: change
 button to 'Restore Revision ID:X' we can translate the words in
 revision.php, i think.


 Replying to [comment:39 helen]:
 > Definitely need to do a review of HTML and CSS naming and structure -
 there's a lot of ID usage going on the CSS that I'm not super convinced
 about as well. ocean90 - do you want to look at that?
 >
 > Other notes I had:
 >
 > * The clearing break at the top pushes the whole wrap down. Does that
 div + br really need to be there? If something appears there (which I
 haven't managed to trigger), it would make the page jumpy, which is also
 not great. I don't think anything should come before or really outside of
 the wrap at all, anyway.
 > * The "Restore" button doesn't tell me what exactly is being restored,
 especially in compare-two mode. Not sure what a good way is to handle
 that, especially given translations, but perhaps adding the revision
 number would be helpful.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:41>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software