[wp-trac] [WordPress Trac] #23642: wp_mail() returns true if sending failed

[WordPress Trac]

#23642: wp_mail() returns true if sending failed
------------------------------+-----------------------
 Reporter:  chmac             |       Owner:
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  3.6
Component:  Mail              |     Version:  3.2
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 SergeyBiryukov]:
 > The test currently passes without the patch.

 With the properly implemented mock PHPMailer from #24662, turned out that
 [attachment:23642-unit-tests.2.diff] actually fails in the last assertion
 without the patch, and passes with
 [attachment:wp_mail_return_false_on_failure.patch].

 Replying to [comment:11 iandunn]:
 > Are you combining them so that the suite runs faster, and then just
 manually checking to make sure that the combined tests don't have any
 side-effects on each other?

 The pattern I see in other tests is that we tend to group similar
 assertions under the same test, if possible (if they don't change the
 global state).

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23642#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software