[wp-trac] [WordPress Trac] #22363: Accents in attachment filenames should be sanitized

WordPress Trac noreply at wordpress.org
Sat Jun 29 10:07:14 UTC 2013


#22363: Accents in attachment filenames should be sanitized
--------------------------+-----------------------------
 Reporter:  tar.gz        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Upload        |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------

Comment (by tar.gz):

 Thanks for those patches!

 I just tested 22363.3.rev24527.patch in combination with
 24661.0.rev24527.patch from #24661 - works great, it fixes the problem.
 Here is my test page: http://sandbox.4o4.ch/wp-git/?p=506

 > By allowing accented characters in URLs, Wordpress relies on the fact
 that nowadays everyone is using a modern browser.

 This is not entirely true, since for *Post URLs*, WP *does* remove
 accented characters.

 Secondly, the reason I brought up this issue, is that one of the "modern
 browsers", Safari (on OSX and iOS) is failing to display files with
 combined characters in their name (unless the url is %-encoded). Depending
 on the country where you live, that can be a significant segment - for
 Switzerland, StatCounter ranks Safari at 20% (and 60% for mobile).

 Finally, those files with combined diacritics are also poorly supported by
 FTP clients. Whenever I have to migrate a WP site, in a French or German
 speaking area, some files will allways be broken during FTP transfer, and
 will need manual replacement. Fixing them at upload would simply eliminate
 all those potential future issues.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22363#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list