[wp-trac] [WordPress Trac] #22501: class-wp-upgrader.php is using the wrong theme directory

[WordPress Trac]

#22501: class-wp-upgrader.php is using the wrong theme directory
-----------------------------+-----------------------------
 Reporter:  toscho           |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Future Release
Component:  Upgrade/Install  |     Version:  2.9
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |
-----------------------------+-----------------------------
Changes (by dd32):

 * keywords:  has-patch => needs-patch


Comment:

 Let me preface this with: This needs to be fixed, don't get me wrong.

 But since this isn't a regression from a previous release (Infact, it's
 been an issue since the upgrader was first added), so is low-priority
 right now while the 3.6 release is wrapped up - The focus of the entire
 dev team is on getting 3.6 finalised, not on fixing old bugs which have
 had no activity at all during the 3.6 cycle, and doesn't cause an issue
 for the 99% of the !WordPress ''users'' out there.

 FWIW, The patch here seemingly fixes the initial problem, and lets you use
 the filter. But what it doesn't do is actually support custom Theme
 directories, for that, the theme stylesheet being updated needs to be
 passed to get_theme_root().

 While we could apply this patch, it's not going to fix it for people who
 actually use multiple theme directories, and may potentially break things
 for them if they're using the filter in a different way than you, testing
 patches and use-cases can take much more time than you might expect, and
 doing that to a core piece of code such as the updater, late in a release
 cycle is rather dangerous.

 Come 3.7 dev time, bump the ticket, and get some eyes on it and the above
 issue fixed, get some proper testing with multiple theme directories
 involved, and get it in early enough in the dev cycle to allow real world
 testing, and you'll be gold.

 As a work-around for now, I'd suggest you look into using a Symlink(or if
 you're using windows which also supports symlinks, a NTFS Junction point
 might also be suitable), to move the directory elsewhere, one of the
 reasons both of those functionalities were added to filesystems were to
 work around cases where paths are hard coded.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22501#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software