[wp-trac] [WordPress Trac] #15015: Customisable submit button for comment form
WordPress Trac
noreply at wordpress.org
Tue Jun 18 18:09:43 UTC 2013
#15015: Customisable submit button for comment form
------------------------------------+-----------------------------
Reporter: morpheu5 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Comments | Version: 3.0.1
Severity: normal | Resolution:
Keywords: dev-feedback has-patch |
------------------------------------+-----------------------------
Comment (by Greenweb):
Any movement on this ?
Replying to [comment:13 coffee2code]:
> As @dd32 stated, the original patch [attachment:comment-template.patch]
does not conform to the WP way of doing things.
>
> I've attached [attachment:15015.diff] as an alternative solution. It
treats the submit button in the same way the comment input field
(comment_field) is handled:
>
> * A `'submit_button'` entry is added to the comment form's `$defaults`
array and contains the base markup for the button. This allows the entire
'input' tag to be filtered via the 'comment_form_defaults' filter.
> * Additionally, also in the same vein as 'comment_field', the finalized
(sprintf()'d) version of the submit button is passed through the new
'comment_form_submit_button' filter. This allows an additional way to
customize the submit button markup prior to display.
>
> This approach is more consistent with what the function already
does/allows and permits arbitrary customization of the submit button
markup.
>
> @morpheu5 could get the 'tabindex' attribute he wants, and @anoited
could add 'class' (which are also the requests in the related tickets I
pointed out) -- both without needing to add specific support for those (or
other) attributes.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15015#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list