[wp-trac] [WordPress Trac] #24216: wp_unique_term_slug uses variable that doesn't exist

[WordPress Trac]

#24216: wp_unique_term_slug uses variable that doesn't exist
--------------------------+------------------
 Reporter:  lonnylot      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Taxonomy      |     Version:  2.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by Sebastian Klier):

 I had a look at this today and I believe the part referenced in the ticket
 can simply be removed. Using
 {{{
 $term->term_id
 }}}
 does not work, as $term was originally cast to stdObject from $args and
 does not have this property. You could look up the ID again, or make more
 changes so we can pass the ID, but I'm not sure that is necessary as the
 method to get the numbered slug has worked like that for years now?

 As mentioned in the comment above, there are many more things going wrong
 here, and I'm not sure what the intended behaviour is, else I would look
 into it further. According to the codex, there should never be duplicate
 names, not even for terms with different parents. However currently it
 seems only the first returned name is checked against, and lower/upper
 case is not taken into account. Duplicate names within other parents seem
 also possible.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24216#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software