[wp-trac] [WordPress Trac] #12706: Custom post status bugs in the admin

[WordPress Trac]

#12706: Custom post status bugs in the admin
-------------------------------------------------+-------------------------
 Reporter:  ptahdunbar                           |       Owner:  ptahdunbar
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Post Types                           |  Release
 Severity:  normal                               |     Version:  3.0
 Keywords:  has-patch westi-likes needs-testing  |  Resolution:
  needs-refresh needs-unit-tests editorial-flow  |
-------------------------------------------------+-------------------------

Comment (by sworddance):

 (Comment from #7745 that seems to be relevant - this comment is more
 expanded)
 It seems the real problem is that there are 2 orthogonal issues at work
 that are not being treated orthogonally: Visibility and Status.

 Currently ( 3.7-alpha24822 ) there are very bizarre interactions as a
 result.

 Interaction path 1:

 1. Create a post
 1. Change its Visibility to Private
 1. Status now changes to 'Privately Published'
 1. Status does not have an edit link any more

 Interaction path 2:

 1. Create a post
 1. Click on Status edit button (so the status selection box is displayed)
 1. Click on Visibility Edit button
 1. Change Visibility to Private
 1. Click on Visibility 'OK' button
 1. Status option box changes to allow 'Pending Review', 'Draft',
 'Privately Published'
 1. Select 'Draft' and click on status 'OK' button.
 1. Status becomes 'Privately Published' ( not Draft like user requested )
 and the edit button disappears.

 Interaction Path 3:
 1. Create a post
 1. Click on Status edit button (so the status selection box is displayed)
 1. Click on Visibility Edit button
 1. Set the scheduled time to be in the future
 1. Change Status to be private
 1. Post published and the scheduled time is still set to be the future.

 Comments:

 1. Visibility and Status are not logically the same :
   1. Visibility is the MAXIMUM POSSIBLE visibility.
   1. Status is a WORKFLOW STATE that may impose a maximum
 calculated_visibility
 1. If Visibility controls Status then Status should be visually
 subordinate to Visibility. Currently it looks like Status should control
 visibility. (which from a work flow perspective I would think that it
 would be the case.)
 1. Visibility and Status interact in a non-intuitive manner.

 Suggestions:

 1. Status should be used to determine the CURRENT maximum visibility of a
 post.
 1. Visibility determines the absolute maximum visibility of the post.

 so conceptual the question is :

 {{{
 current_user_can('read_post', $post_id) ;
 }}}

 with the answer being determined by:

 {{{$actual_visibility = max ( status_max(), visibility_max(), }}}
 {{{      <some calculation depending on current_user's relationship to the
 post>, <posting_schedule>, <other filter functions > ) }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/12706#comment:162>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software