[wp-trac] [WordPress Trac] #6297: Unbalanced tags across more and nextpage tags

WordPress Trac noreply at wordpress.org
Sun Jul 28 20:10:27 UTC 2013


#6297: Unbalanced tags across more and nextpage tags
-----------------------------------+------------------------------
 Reporter:  tellyworth             |       Owner:
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Formatting             |     Version:  2.5
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------
Changes (by mdawaffe):

 * keywords:  has-patch => has-patch 2nd-opinion


Comment:

 attachment:balanceTags_quicktags-trunk.patch​ looks solid to me.
 Refreshed for trunk in attachment:6297.diff.

 Passes all relevant unit tests including the ones that are skipped for
 this ticket:

 {{{
 phpunit --group 6297 tests/post/filtering.php
 }}}

 I don't like the "quicktags" naming.  Maybe "balance_tags_delimiters"?
 Maybe roll the `<!--` and `-->` into the values returned by the filter?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/6297#comment:15>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list