[wp-trac] [WordPress Trac] #24449: Attachment display settings in the Media Library are ignored for audio and video inside 'Standard' post format and pages

[WordPress Trac]

#24449: Attachment display settings in the Media Library are ignored for audio and
video inside 'Standard' post format and pages
--------------------------+--------------------
 Reporter:  sennza        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by nacin):

 [attachment:24449.2.diff] has tested pretty well for me. I tested with
 audio, video, PDF, and image files; and with an audio file that had an
 unsupported extension. (Well, I commented out a supported extension to
 test.)

 It is missing a single piece of abstraction that is really bugging me. The
 logic for canEmbed is duplicated in both media-views and media-editor. It
 could also benefit from review from koopersmith but that can happen post-
 commit.

 While the existing 'link' setting/prop could probably have been used, a
 separate 'embed' setting/prop was used to avoid possible issues with the
 associated user settings. Given 'data-user-setting', this may have been
 mostly without merit, but getUserSetting() does appear in media-editor.js.
 I wanted it to be made clear what was happening, and the separation does
 seem to make sense. (Ideally attachment display settings gets broken up
 into subviews anyway.)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24449#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software