[wp-trac] [WordPress Trac] #24758: Revisions needs to gracefully handle AJAX failures.

WordPress Trac noreply at wordpress.org
Thu Jul 18 00:19:47 UTC 2013


#24758: Revisions needs to gracefully handle AJAX failures.
--------------------------+--------------------
 Reporter:  markjaquith   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Revisions     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by adamsilverstein):

 Replying to [comment:8 ocean90]:
 > The error message is not displayed on first load. But requests stop.

 the first diff is now preloaded in php so you will never see an error
 there. i set up a random error in wp_ajax_get_revision_diffs() and tested,
 with [attachment:24758.6.diff​] i do see the error message briefly, until
 the ajax re-fires and loads correctly. i also observed the number of diffs
 bundled per request reducing to 1 and then giving up on further requests.

 looks good!

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24758#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list