[wp-trac] [WordPress Trac] #23216: Create "WP Heartbeat" API

[WordPress Trac]

#23216: Create "WP Heartbeat" API
--------------------------------------+-----------------------
 Reporter:  azaozz                    |       Owner:
     Type:  task (blessed)            |      Status:  reopened
 Priority:  normal                    |   Milestone:  3.6
Component:  Administration            |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  autosave-redo needs-docs  |
--------------------------------------+-----------------------

Comment (by carldanley):

 Replying to [comment:103 wonderboymusic]:
 > the Revealing Module Pattern is one of the only ways to actually make
 methods actually private, would also delete the need for dangling _, which
 every linter complains about - otherwise, nothing stops API._imPrivate
 from being called, this would:

 This is in fact the pattern I used
 (http://addyosmani.com/resources/essentialjsdesignpatterns/book/#revealingmodulepatternjavascript).
 I think what you're suggesting is the removal of the underscore prefixes
 which are only there as an added benefit in reading the code. Underscore
 prefixes can be removed during minification which is why I believe there
 is added value in the prefix for readability. I'm open to the removal of
 the underscores as it's an easy change.

 > I think it is a little absurd that a rewrite is even being entertained
 during RC.

 If I were to rewrite this code, I would have started from scratch with a
 different approach. I mostly copied and pasted code and cleaned up a lot
 of pieces to match a more solid structure. I also agree that is indeed
 late in the game but I don't think it would be hard to entertain this
 given the API matches and things work the same as they did before.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23216#comment:105>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software