[wp-trac] [WordPress Trac] #24757: Diff timeout of 1 second is not sufficient.

[WordPress Trac]

#24757: Diff timeout of 1 second is not sufficient.
--------------------------+--------------------
 Reporter:  markjaquith   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.6
Component:  General       |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:                |
--------------------------+--------------------

Comment (by nacin):

 The default max_execution_time is 30, so 5 seems low.

 We're really just trying to give the script as much time as it needs, as
 30 may not be enough. One option is to give each revision a few seconds by
 calling set_time_limit() within the loop.

 Maybe we should just do set_time_limit( 0 ) and also make sure (if we
 don't already) that we don't request an unreasonably high number of items
 at once via JS. If 30 isn't enough, then perhaps we're also requesting too
 many at once. Perhaps if the request times out, errors out, or takes more
 than X seconds, we need to cut in half the number of revisions we just
 tried to request.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24757#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software