[wp-trac] [WordPress Trac] #24425: Revisions cleanup

WordPress Trac noreply at wordpress.org
Wed Jul 10 13:29:40 UTC 2013


#24425: Revisions cleanup
----------------------------+--------------------
 Reporter:  markjaquith     |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  high            |   Milestone:  3.6
Component:  Revisions       |     Version:  trunk
 Severity:  blocker         |  Resolution:
 Keywords:                  |
----------------------------+--------------------

Comment (by duck_):

 [24627] caused the previous/next buttons to not be present on initial
 load. They appear again if you toggle the checkbox. The problem that the
 `compareTwoMode` attribute doesn't have a default value, so the call to
 `get()` returns `undefined`. `toggleClass()` will then add the `comparing-
 two-revisions` class since it was not passed a boolean.

 Adding a default of false in the FrameState model fixed this for me. It
 looks like it should always start in single comparison mode, but I wasn't
 entirely sure.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24425#comment:54>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list