[wp-trac] [WordPress Trac] #17923: add_query_arg() should encode values

[WordPress Trac]

#17923: add_query_arg() should encode values
---------------------------------+-----------------------------
 Reporter:  Viper007Bond         |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  General              |     Version:  3.2
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.6-early  |
---------------------------------+-----------------------------
Changes (by DeanMarkTaylor):

 * cc: deanmarktaylor@… (added)


Comment:

 Both '''keys''' and values should be encoded, perhaps something like:
 {{{
 $kayvees = array_combine(
         array_map( 'rawurlencode_deep', array_keys( $kayvees ) ),
         array_map( 'rawurlencode_deep', array_values( $kayvees ) )
 );
 }}}

 Perhaps {{{WP::build_query_string}}} needs reviewing too regarding
 encoding keys?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/17923#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software