[wp-trac] [WordPress Trac] #24425: Revisions cleanup

WordPress Trac noreply at wordpress.org
Thu Jul 4 08:17:14 UTC 2013


#24425: Revisions cleanup
----------------------------+--------------------
 Reporter:  markjaquith     |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  high            |   Milestone:  3.6
Component:  Revisions       |     Version:  trunk
 Severity:  blocker         |  Resolution:
 Keywords:                  |
----------------------------+--------------------

Comment (by markjaquith):

 [attachment:24425.history-debounce.diff​ 24425.history-debounce.diff]

 The URL updating on mouse drag was massively slowing things down. This
 patch makes a debounced function (250ms currently), and then only calls
 that from a custom event that fires after the diff has rendered (diff
 rendering has its own throttling built in, so this will filter out diffId
 changes that happen so quickly that by the time they start to render, the
 diffId has already changed.

 Also a little bit of cleanup, removing unnecessary variables, and moving
 the Router to get passed in a model, instead of the set-it-after thing
 that was happening.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24425#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list