[wp-trac] [WordPress Trac] #24425: Revisions cleanup

[WordPress Trac]

#24425: Revisions cleanup
----------------------------+--------------------
 Reporter:  markjaquith     |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  high            |   Milestone:  3.6
Component:  Revisions       |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+--------------------

Comment (by adamsilverstein):

 in [attachment: 24425.draft.29.diff]
 Corrected:
 * Corrects tooltip is misplaced when in compare-2-mode
 * Removed bottom border from .revisions-controls div
 * Removed markup for tick marks
 * Remove markup for the spinner
 * Moved if ( this.model.revisions.length < 3 ) to checkbox view
 * remove $( '.compare-two-revisions' ).trigger( 'click' ); instead rely on
 route actions only (started)
 * Tooltip message moved into model for easier translation
 * Switched to new View for tooltip

 Still Remaining:
 * RTL mode 2 handles
 * Improve getSliderPosition(), use more. (Idea: return an array with left
 and right, if single only left is filled with a value)
 * Restore the .pre class for the diff table
 * remove revision id from URL, instead pass post_id and
 #route/to/revision_id

 Bugs

 * Compare-2-mode: Right handler on the first revisions, left on the last:
 Expected: See all lines in green color, since it's a diff from the first
 to the current one
 * Router: If reloading a page it loses the handle positions (currently
 being messes with by passed revision id)
 * duplicate firing on next/previous

--
Ticket URL: <http://core.trac.wordpress.org/ticket/24425#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software