[wp-trac] [WordPress Trac] #23305: Correction of some minor HTML output issues

WordPress Trac noreply at wordpress.org
Sun Jan 27 18:35:56 UTC 2013


#23305: Correction of some minor HTML output issues
-----------------------------+-----------------------------
 Reporter:  fob              |       Type:  feature request
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  Comments
  Version:  trunk            |   Severity:  trivial
 Keywords:  needs-refresh    |
-----------------------------+-----------------------------
 Even in the latest comment-template.php I found some functions that use
 single quotes for the HTML output of links instead of double quotes. It
 works. But wouldn`t it be nicer to avoid a mix of notations in the source
 code? I personally prefer to use single quotes within functions and double
 quotes for the HTML output. However. Consistent code should be better than
 a mix of all. So I would like to suggest renewing some functions like:

 - get_comment_author_email_link
 {{{ ( $return .= '<a href="mailto:'.$email.'">'.$display.'</a>'; ) }}}

 - get_comment_author_link
 {{{ ( $return = '<a href="'.$url.'" rel="external nofollow"
 class="url">'.$author.'</a>'; ) }}}

 - get_comment_author_url_link
 {{{ ( $return = $before.'<a href="'.$url.'"
 rel="external">'.$display.'</a>'.$after; ) }}}

 and perhaps
 - get_comment_reply_link
 - get_post_reply_link

 in order to output double quotes as they are used within most of the other
 functions that prepare links for the HTML output.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23305>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list