[wp-trac] [WordPress Trac] #16215: Post Revision history displays the incorrect author

[WordPress Trac]

#16215: Post Revision history displays the incorrect author
--------------------------------------------------+-----------------------
 Reporter:  mdawaffe                              |       Owner:  westi
     Type:  defect (bug)                          |      Status:  accepted
 Priority:  normal                                |   Milestone:  3.6
Component:  Revisions                             |     Version:  2.6
 Severity:  normal                                |  Resolution:
 Keywords:  dev-feedback needs-testing has-patch  |
--------------------------------------------------+-----------------------

Comment (by adamsilverstein):

 i'm working on getting this ticket resolved! thought i would start by
 testing the patch provided by mdawaffe.

 the patch did not apply cleanly, but i was able to get it applied to
 current and tested locally using three users. the patch works, with some
 minor issues, i think its easiest to see in screen shots.

 for each of the tests i created a post with the content 'admin' as the
 user admin, next i switched to user 'testuser' and edited the content to
 be 'testuser', next i switched to 'testuserb' and changed the content to
 'testuser B', finally i logged as the user admin and checked revisions.
 the screenshots show the meta box on the edit post screen and the
 revisions review screen as well as each revision comparison.

 [http://www.earthbound.com/wordpress-revisions-testing-review-new-post-
 created-before-patch-applied new post created before patch applied] - here
 we see the bug in action, comparison users are all off. note that the meta
 box on the post edit page actually looks right (i think).

 [http://www.earthbound.com/wordpress-revisions-testing-review-new-post-
 created-after-patch-applied new post created after patch applied] - the
 patch fixed all the comparisons, yea! except...

 note: there two revisions listed for my initial admin action of creating
 the post, the first is triggered when i left the title field, the second
 being my 'publish' action (publishing with only a title in another test
 removed this extra initial revision) . this seems like it would be
 confusing to end users, shouldn't the initial revision (shown) be my first
 publish?

 also note another problem here, the meta-box on the post edit page shows
 one admin revision, one testuser revision, but no testuserb revision,
 which was the last revision. i'm logged back in as admin and haven't hit
 update yet - i should see testuserb's change in the revision list, and I
 DO in fact see it once i go to the compare revisions screen. this seems
 like a new bug/regression and needs fixing, might just be showing one too
 few revisions.

 [http://www.earthbound.com/wordpress-revisions-testing-review-post-
 created-before-patch-applied-viewed-after-patch-applied post created
 before patch applied, viewed after patch applied] - the patch works as
 advertised on the comparison screen, the post created without the patch
 now looks good on the comparison screen and UPDATES should be apply-able.
 exhibits same issue with meta-box on post edit page as in 2nd case above.

 what remains to-do:

 * fix issue with meta box display
 * add UPDATE statements

 things to consider:

 * is using menu_order for revisions a good idea? better approach? here
 were comments from original patch "I took the menu_order approach outlined
 above in the ticket, but used comment_count instead since a page's
 menu_order is actually versioned by the revisioning system. This
 comment_count trick won't work if plugins (or future core) allow comments
 on revisions. As an alternative, we could hack the version into
 post_name." any other input here or leave as is?
 * address this issue from original ticket?:  "Currently, post_modified is
 identical to post_date, which is the time the post was put into the state
 represented by the revision. We could make post_modified the time the post
 was edited away from the state represented by the revision." comments? is
 this issue in the post or in the revisions? move to another ticket

 *more testing, unit tests?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16215#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software