[wp-trac] [WordPress Trac] #23170: PHP Notice On _remove_theme_support() function

[WordPress Trac]

#23170: PHP Notice On _remove_theme_support() function
------------------------------+------------------
 Reporter:  alex-ye           |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.6
Component:  Warnings/Notices  |     Version:  3.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------

Comment (by alex-ye):

 Replying to [comment:2 SergeyBiryukov]:
 > However, seems like the check in [22313] was inaccurate: `did_action()`
 can only return an integer. [attachment:23170.patch] fixes the condition.

 Good , but I have a tiny question why we check '''$support[0]['wp-head-
 callback']''' in line 1495 it is not a boolean var and we should use
 empty() or isset() ... right ?!

 And what about the line 1505 we don't check '''$support[0]['wp-head-
 callback']''' at all , so what is the difference ?!

 after all I want to learn more from you guys :)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23170#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software