[wp-trac] [WordPress Trac] #10948: wp_list_comments() always assumes walker will echo.

WordPress Trac noreply at wordpress.org
Thu Jan 10 16:23:58 UTC 2013


#10948: wp_list_comments() always assumes walker will echo.
--------------------------+--------------------
 Reporter:  MikeLittle    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.6
Component:  Comments      |     Version:  2.8.6
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------

Comment (by MikeLittle):

 The [http://core.trac.wordpress.org/raw-attachment/ticket/10948/return-wp-
 list-comments.diff return-wp-list-comments.diff]​ patch still applies
 cleanly for me on today's trunk (revision #23296).

 The code works fine:
 Adding an 'echo' => false parameter to the call to wp_list_comments in
 comments.php in twentytwelve theme produces no comment output (o the flag
 works).
 Adding an echo to the front of that function call produces exactly the
 same output as without the patch.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/10948#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list