[wp-trac] [WordPress Trac] #19239: Combine WordPress News and Other WordPress News dashboard widgets
WordPress Trac
noreply at wordpress.org
Thu Jan 10 15:40:26 UTC 2013
#19239: Combine WordPress News and Other WordPress News dashboard widgets
-----------------------------+------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.6
Component: Administration | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------------+------------------
Comment (by ericmann):
The way things originally worked:
- There was one RSS widget function that took some generic parameters
(url, show_author, show_summary, show_date, limit) and returned a cachable
result with some default markup.
- The functions that registered both original "official" feed widgets
merely called this same function but passed different parameters - the
official blog shows excerpts, the WordPress Planet feed doesn't
Since you can still add generic RSS feeds, I took the approach of
combining these two widgets into a ''non-generic'' feed widget, specific
to the feeds generated by WordPress.org.
Replying to [comment:4 SergeyBiryukov]:
> Current widgets allow to change the RSS feed URL and title, for example
to replace the English feed with a localized one.
So far as I knew at the time (and please correct me if I'm wrong) there
isn't a multi-language setup for either http://wordpress.org/news or
http://planet.wordpress.org. I was taking the approach that other
language feeds could be added either through the generic RSS widget or by
adding a language-specific RSS widget.
Replying to [comment:8 bpetty]:
> If the current RSS widget methods aren't currently flexible enough to
implement this widget, it makes sense to me to refactor and expand their
functionality so they can also be used with more 3rd party widgets using
an approach similar to this one. What doesn't make sense is writing up a
second set of methods that provide the same functionality that have to be
maintained right alongside the original methods.
I modeled this widget not after the generic RSS widgets - those are
intended specifically to pull/cache a single feed and display its items on
the screen. Instead, I modeled it after the ''plugins'' widget that grabs
two separate feeds and displays both on the screen.
The use-case here is specific enough (i.e. more than one feed, displayed
differently) that abstracting the standard RSS widget functionality (which
is used elsewhere) didn't make sense. Including functionality to
highlight the official blog (adding the WP logo) wouldn't work in a more
generic method, either.
Also note that the plugins widget doesn't include configuration options
either. So if we are going to add configuration settings to this widget,
my push back would be: ''why?'' Are we adding settings for the sake of
adding settings? Remember, '''decisions, not options.'''
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19239#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list