[wp-trac] [WordPress Trac] #15936: IPv6 literal support in multisite broken
WordPress Trac
noreply at wordpress.org
Tue Jan 8 20:54:25 UTC 2013
#15936: IPv6 literal support in multisite broken
--------------------------+-----------------------------
Reporter: jmdh | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: General | Version: 3.0.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-----------------------------
Comment (by F J Kaiser):
Replying to [comment:6 mitchoyoshitaka]:
> Looks like this patch also helps with situations where the site is
indeed running on a nonstandard port.
>
> I'm concerned, however, that `$_SERVER['HTTP_HOST']` is actually used in
a number of places in the code, including situations where it is used in
building a URL for printing and redirecting. Suppose we have WP on
server:8080. We go into server:8080 and, with this patch, WP will no
longer balk, but some functions such as auth_redirect will end up using
the server:80 equivalent of the URL. Just munging `$_SERVER['HTTP_HOST']`
doesn't seem to be the right approach here.
WordPress already replaces the value of the global
{{{$_SERVER['HTTP_HOST']}}} to one without {{{:PORT_NR}}} attached, so we
know this one is working. Just take a look at
[https://github.com/WordPress/WordPress/blob/3.5/wp-includes/ms-
settings.php#L29 WordPress at GitHub ms.settings.php]. I also worked in the
related {{{$_SERVER['SERVER_NAME']}}} (as we can't rely on either) in
#21077 (which I now closed in favor of this ticket).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/15936#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list