[wp-trac] [WordPress Trac] #22234: Use access modifiers in classes, not the var keyword

[WordPress Trac]

#22234: Use access modifiers in classes, not the var keyword
----------------------------+------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  3.6
Component:  General         |     Version:  1.5
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------
Changes (by wonderboymusic):

 * milestone:  Future Release => 3.6


Comment:

 Uploaded a new patch that uncontroversially only touches properties that
 were already public. It ignores all of the properties marked with `var`
 and an `@access` doc block of private or protected. I removed the public
 `@access` blocks.

 The `@access` doc block is weird. It is not supposed to document an access
 modifier, or override it in documentation. It is supposed to be used to
 suppress documentation of certain elements in your code:
 http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.access.pkg.html

    Protected is allowed, but does absolutely nothing.

 While technically that might have been what people had in mind while using
 it, it seems like it is being used to control access, which access
 modifiers do automatically. Also, I doubt there is code that people
 explicitly want to not document - since the documentation generator will
 catch the `private` access modifier and mark things as such.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22234#comment:5>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software