[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

[WordPress Trac]

#23497: Revisions Rewrite using JS/Backbone
--------------------------------------------------+------------------------
 Reporter:  adamsilverstein                       |       Owner:  westi
     Type:  enhancement                           |      Status:  reviewing
 Priority:  normal                                |   Milestone:  3.6
Component:  Revisions                             |     Version:  3.5.1
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch needs-refresh dev-feedback  |
--------------------------------------------------+------------------------

Comment (by adamsilverstein):

 Replying to [comment:35 azaozz]:
 > Some quick notes:
 >
 > - jquery-ui-slider.css references about 10 images that are missing.
 Apparently the slider works without them (regardless of the browser
 console filling with 404s). Perhaps it needs some changes to exclude these
 backgrounds or replace couple of them them with gradients?
 > - Does template.js need to load every time backbone.js is loaded
 (doesn't seem needed for media)? Is there a better place for this function
 instead of a separate file (since it's only about 10 lines).
 >
 > And some nitpicking:
 > - Looking at ajax-actions.php: $showautosaves and $showsplitview appears
 to be boolean, why not check them with `! empty()`. Also `$postid` should
 probably be `$post_id` as most other places in the admin, `foreach` blocks
 should be indented, and there seems to be a typo on
 [http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/ajax-
 actions.php#L2156 line 2156].

 thanks; i will correct the variable names, my mistake for not following
 convention. if you want to get rid of the console errors for now, the
 missing images are here:
 http://core.trac.wordpress.org/attachment/ticket/23497/wp-includes-
 images.2.zip

 will also adjust boolean checks, thanks for the tip.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:37>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software