[wp-trac] [WordPress Trac] #23626: wp_convert_bytes_to_hr tests and NaN

[WordPress Trac]

#23626: wp_convert_bytes_to_hr tests and NaN
--------------------------+-----------------------------
 Reporter:  soulseekah    |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:7 soulseekah]:
 > Perhaps it should return false for all sorts of weirdness? Or 0B.

 It's supposed to return a string. It also does not state that `$bytes`
 should be positive, so for "-1", I guess "-1B" is a more appropriate
 result than "0B".

 We could also add "TB" to the array: [attachment:23626.2.patch],
 [attachment:23626.test.2.patch].

 So far getting consistent results with the latest patches.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23626#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software