[wp-trac] [WordPress Trac] #23626: wp_convert_bytes_to_hr tests and NaN

WordPress Trac noreply at wordpress.org
Thu Feb 28 06:13:21 UTC 2013


#23626: wp_convert_bytes_to_hr tests and NaN
--------------------------+-----------------------------
 Reporter:  soulseekah    |       Owner:  SergeyBiryukov
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.6
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Still getting different results:
 * 32-bit, `wp_convert_bytes_to_hr( -1 )`: `NANB`
 * 64-bit, `wp_convert_bytes_to_hr( -1 )`: `-1B`

 I didn't commit [attachment:19067.function.patch] as is, because for 1
 terabyte, the function would return "1B" (before [23502] it would be "1"
 and a notice).

 Testing [attachment:23626.patch] and [attachment:23626.test.patch] now.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23626#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list