[wp-trac] [WordPress Trac] #23347: Theme fallbacks for post format meta data
WordPress Trac
noreply at wordpress.org
Wed Feb 27 20:50:32 UTC 2013
#23347: Theme fallbacks for post format meta data
--------------------------+------------------
Reporter: helen | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.6
Component: Post Formats | Version:
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by Otto42):
For the case of brand new websites running themes without structured-post-
formats but with normal-post-formats, I'm okay with post_formats_compat(),
although it does need some minor improvements.
The specific problem I encountered was basically because it's only
examining the input $content data, which doesn't get the complete content
in the case of a !--more-- tag situation (and probably will have the same
issue with !--nextpage--). For it to work properly, post_formats_compat()
needs to examine the entire post. It can do this by looking at the
$post->post_content directly instead and that would fix the immediate
issue. Minor change to the preg_match_all on line 371 would probably do
the job.
For the case of older websites, I'd rather it not do anything at all, or
even have that filter be connected. Many people with existing sites won't
be happy to upgrade and notice posts looking different, even if we think
they may be "better". Set an option on upgrade to prevent that filter from
attaching and it's fine. This isn't without precedent, look at the Links
menu in 3.5.
No opinion on audio/video as yet, however it's not unfeasible that some
people have used the video format and then been posting something like
youtube links in the post and such. Making any assumptions here about what
the old-post should contain is probably ill-advised.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23347#comment:39>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list