[wp-trac] [WordPress Trac] #21256: New theme feature - add_theme_support( 'content-width', $defaults )

WordPress Trac noreply at wordpress.org
Mon Feb 25 21:26:47 UTC 2013


#21256: New theme feature - add_theme_support( 'content-width', $defaults )
--------------------------------------+------------------------------
 Reporter:  ramiy                     |       Owner:
     Type:  feature request           |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Themes                    |     Version:  3.4.1
 Severity:  normal                    |  Resolution:
 Keywords:  dev-feedback 2nd-opinion  |
--------------------------------------+------------------------------

Comment (by DrewAPicture):

 Replying to [comment:23 maor]:
 > I also tend to think that it's more of a theme feature. Having it as a
 global variable is quite risky, since plugins and themes can override this
 variable by mistake.

 I think we'd have to keep the global for back-compat anyway.

 Not sure I'm completely onboard with doing a defaults array per-post type
 as suggested above though. I'd be tempted to roll this into an
 `add_theme_support()` implementation then still have themes filter the
 value that goes in based on their own conditions.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21256#comment:24>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list