[wp-trac] [WordPress Trac] #23497: Revisions Rewrite using JS/Backbone

WordPress Trac noreply at wordpress.org
Sun Feb 24 23:53:59 UTC 2013


#23497: Revisions Rewrite using JS/Backbone
--------------------------------------------------+--------------------
 Reporter:  adamsilverstein                       |       Owner:
     Type:  enhancement                           |      Status:  new
 Priority:  normal                                |   Milestone:  3.6
Component:  Revisions                             |     Version:  3.5.1
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch needs-refresh dev-feedback  |
--------------------------------------------------+--------------------

Comment (by adamsilverstein):

 Uploading a new version, ready for testing

 '''Notes'''
  * allows comparison of two revisions, using range slider
  * when in compare two mode, the left most spot in the slider represents
 the 'current revision'
  * when in compare one mode, the comparison is always to the current
 version, the leftmost slider spot represents the 1st (most recent)
 revision
  * slider leftmost position is most recent, rightmost oldest - is this
 obvious?
  * currently using range slider which prevents handles from crossing
 automatically; a two handled slider would also work, with some code
 changes
  * updated wp-includes images folder (gray color for range bar)
  * code refactored for cleaner interactions, but still plenty of room for
 improvement!
  * code prevents overlapping handles, eg. compare to self, bye bye easter
 egg? suggestions?
  * current version shows info about revisions being compared on same line,
 in compare two revisions mode, these only fit on a wide screen; probably
 need to create a separate row for compare from details.
  * expanded meta info, possibly needs shortening
  * showing/hiding divs to keep words 'current version' translatable and in
 the PHP not JS side, is there a better way?
  * when in compare two mode, all diffs are calculated for right and left
 handles whenever sliding stops - the appropriate model is loaded as soon
 as sliding begins again, possible to get blank diffs when comparing

 '''TODO notes:'''
  * currently always restores right handle position in compare two mode,
 should we add restore left/restore right? 2nd restore button?
  * update restore action:
   * capture and store the restore event in post meta
 ('post_restored_from') as per
 [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2013-02-21&sort=asc#m560717 IRC] - store: revision id, date of
 restore, user who restored;
   * edit_last and post_author set to current user - see #20982.
  * update meta box on edit post screen, show revision meta info: count,
 earliest, oldest; remove link from publish box
  * verify all filters working, and new hooks?

 '''Screenshots:'''

 Compare two:
 [[Image(http://f.cl.ly/items/2z3l2T0x0E250R2Z1e3N/revisions2.png)]]

 Compare one:
 [[Image(http://f.cl.ly/items/2J0Q2b2F401s3u0B130b/revisions.png)]]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23497#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list