[wp-trac] [WordPress Trac] #23282: Add shortcodes for inline HTML5 audio / video

WordPress Trac noreply at wordpress.org
Fri Feb 22 22:36:39 UTC 2013


#23282: Add shortcodes for inline HTML5 audio / video
-----------------------------+------------------
 Reporter:  wonderboymusic   |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  normal           |   Milestone:  3.6
Component:  Media            |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------

Comment (by beaulebens):

 I tested out 23282.6.diff, and here are some notes/questions/etc:

 * Really like the Insert into Post action from the Media Manager when you
 upload audio/video; hotness
 * I tested output in /Twenty (Ten|Eleven|Twelve|Thirteen)/ and it worked
 in all of them OOTB
 * {{{get_post_audio()}}} doesn't return anything if it doesn't find audio
 children. Probably should return either false or an empty array
 * {{{get_content_audio()}}} also doesn't return anything if there's
 * {{{get_content_audio()}}} and {{{get_content_video()}}} probably need to
 use the {{{/i}}} modifier on the regex to catch upper case html. Might
 also want to set the {{{$count}}} param in str_replace for a regexed out
 tag just to be safe and only ever remove one instance
 * Extra space character on line 1753 of {{{wp-includes/media.php}}}
 * For the fallbacks in {{{post_formats_compat()}}} where a link is
 inserted, it's probably worth adding a standardized class to them (class
 ="wp-post-format-link-$format" or something?) Applies to #23347 also.
 * Should {{{post_formats_compat()}}} now have defaults for audio/video of
 their shortcodes?
 * MediaElements is licensed MIT, so it's GPL-compat. It also has a long
 dev history (back to '09) and seems actively maintained, so it looks like
 a nice choice for core.
 * We might want to make the default color scheme for the media players a
 bit more "generic" perhaps.
 * I haven't tried it, but I assume there are going to be conflicts with
 plugins that are using the audio/video shortcodes -- not sure what the
 best way of handling them is.

 I think it's worth getting this into core to try it out along with the
 other post formats work, since without it, the PF stuff is kind of half-
 hearted.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23282#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list