[wp-trac] [WordPress Trac] #20534: Featured Image (Post Thumbnail) SSL Issue

[WordPress Trac]

#20534: Featured Image (Post Thumbnail) SSL Issue
-------------------------------------+------------------------------
 Reporter:  justindgivens            |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Post Thumbnails          |     Version:  2.9
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |
-------------------------------------+------------------------------

Comment (by AaronAsh):

 Hi,
 I ran into this problem with wordpress 3.4.2 today and manually patched it
 using the attached fix.
 I also noticed that there's a bug in the latest fix:
 http://core.trac.wordpress.org/attachment/ticket/20534/20534.3.diff

 The following if statement should have brackets:
 {{{
 #!php
         if ( $src && $width && $height )
                         if( is_admin() )
                                 $src = set_url_scheme( $src, 'admin' );
                         else
                                 $src = set_url_scheme( $src );
                         return array( $src, $width, $height );
                 return false;
         }
 }}}

 Like so:
 {{{
 #!php
                 if ( $src && $width && $height ) {
                         if( is_admin() )
                                 $src = set_url_scheme( $src, 'admin' );
                         else
                                 $src = set_url_scheme( $src );
                         return array( $src, $width, $height );
                 }
                 return false;
         }
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20534#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software