[wp-trac] [WordPress Trac] #23396: Revision team proposed changes patches for testing

[WordPress Trac]

#23396: Revision team proposed changes patches for testing
------------------------------------+--------------------
 Reporter:  adamsilverstein         |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.6
Component:  Revisions               |     Version:  3.5.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+--------------------

Comment (by adamsilverstein):

 looks like its straightforward to add a second handle to the slider.
 technically this is not a range slider, just a two handles slider.

 the comparison code always compares the newer to the older revision, so i
 think it makes sense that the sliders can't overlap and also block each
 other.

 for example: you have 10 revisions, by default you are comparing the
 current version to the 1st (most recent) revision (or another revision if
 you clicked on it in the list perhaps).  the current version would be
 represented by the leftmost position on the slider, the next spot to the
 right would be the 1st revision now, you drag the right hand slider handle
 to the right so you are comparing say current to revision 8. next, you
 drag the left hand slider handle to the right, which shows comparisons
 between the revision you drag to (left) and revision 8 (right), but you
 can't go past revision 7 (one to the left of where the right handle is
 set). you leave the left handle at revision 3, the display is comparing
 revision 3 & revision 8. at this point, you can start dragging the right
 handle and you are viewing diffs from revision. again the right handle is
 bound by the left, so you can't go past revision 4 one to the right of the
 left handle.

 this logic is a visual representation of what the current code actually
 does, it always compares newer->older, and it doesn't allow you to compare
 a revision to itself (although its fun to try). the left handle is the
 left revision and the right handle is the right revision.

 thoughts?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23396#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software