[wp-trac] [WordPress Trac] #22324: sanitize_post_field() forgets some integer fields

[WordPress Trac]

#22324: sanitize_post_field() forgets some integer fields
------------------------------+-----------------------------
 Reporter:  GeertDD           |       Owner:  SergeyBiryukov
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  3.6
Component:  General           |     Version:  3.4.2
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------------

Comment (by johnbillion):

 Replying to [comment:15 westi]:
 > I'm not 100% sure this is a good change to make without further review
 and testing.
 >
 > One thing that is probably broken by this change is anything that does
 post author highlighting of comments because '''get_comments''' returns
 straight db data with everything as strings.
 >
 > We use a value and type '''===''' check here -
 https://core.trac.wordpress.org/browser/trunk/wp-includes/comment-
 template.php#L316
 >
 > Which now will fail as one will be an int and one a string.
 This does indeed break post author highlighting. Twenty Twelve which is no
 longer highlighting post author comments because it does an identicality
 check here: http://core.trac.wordpress.org/browser/tags/3.5.1/wp-
 content/themes/twentytwelve/functions.php#L291

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22324#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software