[wp-trac] [WordPress Trac] #23347: Theme fallbacks for post format meta data
WordPress Trac
noreply at wordpress.org
Mon Feb 18 02:08:02 UTC 2013
#23347: Theme fallbacks for post format meta data
-------------------------+------------------
Reporter: helen | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.6
Component: Template | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------
Comment (by helen):
[attachment:23347.5.diff] continues on from .4:
* Made the compat wrapper class generic - thinking CSS should look like
`.chat .post-format-content` rather than `.chat-post-format-content`.
`post_class()` gives that to us, and a filter is included should a theme
author really want to do something to it.
* Compat wrapper is only wrapped around the compat output itself, not
around the entirety of the content + compat output. There was some
funkiness happening because of that, and it doesn't make much sense the
other way around.
* Removed audio/video shortcodes for now, because it's useless without
#23282. If we get #23282 done, we can restore it.
* As noted for .4, chat is removed because it just wasn't working well and
we want to get this in soon. Iteration welcome :)
Thing I noticed, not sure if we need to address now or not: using the
embed shortcode in the fallback for audio/video means that if the user
enters something funky like "http://blah.com and some more stuff" it
`esc_url()`s the whole thing and makes it a link in
`WP_Embed::maybe_make_link()`. It happens if you do it in the content too,
so maybe it's something to make better in `maybe_make_link()`, or it's
fine because that would be a weird thing to do, anyway.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23347#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list