[wp-trac] [WordPress Trac] #21767: Remove stripslashes from API functions

[WordPress Trac]

#21767: Remove stripslashes from API functions
-------------------------------------------------+-------------------------
 Reporter:  alexkingorg                          |       Owner:
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  3.6
Component:  Formatting                           |     Version:  3.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |
  tests 3.6-early                                |
-------------------------------------------------+-------------------------

Comment (by ryan):

 In [changeset:"23416"]:
 {{{
 #!CommitTicketReference repository="" revision="23416"
 Change all core API to expect unslashed rather than slashed arguments.

 The exceptions to this are update_post_meta() and add_post_meta() which
 are often used by plugins in POST handlers and will continue accepting
 slashed data for now.

 Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed
 alternatives to update_post_meta() and add_post_meta(). These functions
 could become methods in WP_Post so don't use them too heavily yet.

 Remove all escape() calls from wp_xmlrpc_server. Now that core expects
 unslashed data this is no longer needed.

 Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data
 being prepared for handoff to core functions that until now expected
 slashed data. Adding slashes in no longer necessary.

 Introduce wp_unslash() and use to it remove slashes from GPCS data before
 using it in core API. Almost every instance of stripslashes() in core
 should now be wp_unslash(). In the future (a release or three) when GPCS
 is no longer slashed, wp_unslash() will stop stripping slashes and simply
 return what is passed. At this point wp_unslash() calls can be removed
 from core.

 Introduce wp_slash() for slashing GPCS data. This will also turn into a
 noop once GPCS is no longer slashed. wp_slash() should almost never be
 used. It is mainly of use in unit tests.

 Plugins should use wp_unslash() on data being passed to core API.

 Plugins should no longer slash data being passed to core. So when you
 get_post() and then wp_insert_post() the post data from get_post() no
 longer needs addslashes(). Most plugins were not bothering with this. They
 will magically start doing the right thing. Unfortunately, those few souls
 who did it properly will now have to avoid calling addslashes() for 3.6
 and newer.

 Use wp_kses_post() and wp_kses_data(), which expect unslashed data,
 instead of wp_filter_post_kses() and wp_filter_kses(), which expect
 slashed data. Filters are no longer passed slashed data.

 Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

 In wp_get_referer() and wp_get_original_referer(), return unslashed data.

 Remove old stripslashes() calls from WP_Widget::update() handlers. These
 haven't been necessary since WP_Widget.

 Switch several queries over to prepare().

 Expect something to break.

 Props alexkingorg
 see #21767
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21767#comment:69>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software