[wp-trac] [WordPress Trac] #23449: Refactor customizer accordion to work anywhere in admin
WordPress Trac
noreply at wordpress.org
Thu Feb 14 14:28:05 UTC 2013
#23449: Refactor customizer accordion to work anywhere in admin
--------------------------------------------+------------------
Reporter: lessbloat | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.6
Component: Appearance | Version:
Severity: normal | Resolution:
Keywords: needs-patch 3.6-menus ui-focus |
--------------------------------------------+------------------
Comment (by lessbloat):
Replying to [comment:6 aaroncampbell]:
> I'd like to fix some things that prevent them from being nested because
someone is going to try to nest them (you know they will).
>
> That means using closest() instead of parents(), changing `$(
'.accordion-section' ).not( clicked ).removeClass( 'open' ); ` to
`clicked.closest( '.accordion-container' ).find( '.accordion-section'
).not( clicked ).removeClass( 'open' );`, and changing all uses of id to
class.
Good call. 23449.1.diff should take care of those items. I just pulled
the "Scroll up if on #accordion-section-title_tagline" code altogether as
it's too specific to the one implementation, and to be honest, I don't
think it improves the experience.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23449#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list