[wp-trac] [WordPress Trac] #23443: Change in behaviour of 'wp_signup_location' filter since WordPress 3.5

[WordPress Trac]

#23443: Change in behaviour of 'wp_signup_location' filter since WordPress 3.5
-------------------------------+------------------------------
 Reporter:  Cimmo              |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Multisite          |     Version:  3.5.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+------------------------------
Changes (by ocean90):

 * keywords:   => reporter-feedback


Old description:

> '''NOTE: This is a detailed ticket that goes deep into WordPress 3.4 vs
> 3.5 changes, I spent 1 hour to understand why the issue happens, so
> please do not close it right away as you usually do.'''
>
> Plug-in's author epic:
> My plug-in used to attach to the filter 'wp_signup_location' to add a
> parameter like '?blog_id=7', this to remember where the user clicked
> 'Register' from.
> In example from:
>
> {{{
> http://localhost/wordpress-ms34/wp-signup.php
> }}}
>
> to:
>
> {{{
> http://localhost/wordpress-ms34/wp-signup.php?blog_id=7
> }}}
>

>
> Behaviour in WordPress 3.4 MS and earlier:
> My plug-in successfully modified the signup location adding the parameter
> needed.
> 1. wp-login.php redirects to the filtered url
> 2. wp-signup.php checks if it !is_main_site(), but till 3.4 not passing
> any parameter to is_main_site was basically always returning true, and
> !true always false.
>
> Behaviour in WordPress 3.5 MS and later:
> 1. wp-login.php redirects to the filtered url
> 2. wp-signup.php checks if it !is_main_site(), this returns true (it is
> not) and then passes and then redirect once more using network_site_url
> 3. network_site_url seems removing any parameter added, jeopardizing my
> filter added earlier.
>
> The exact patch that changed this (correctly probably) is this one:
> http://core.trac.wordpress.org/attachment/ticket/22090/22090.diff
>
> My question is: now, how can have my added parameter not filtered out?
>
> thank you
> Marco

New description:

 Plug-in's author epic:
 My plug-in used to attach to the filter 'wp_signup_location' to add a
 parameter like '?blog_id=7', this to remember where the user clicked
 'Register' from.
 In example from:

 {{{
 http://localhost/wordpress-ms34/wp-signup.php
 }}}

 to:

 {{{
 http://localhost/wordpress-ms34/wp-signup.php?blog_id=7
 }}}



 Behaviour in WordPress 3.4 MS and earlier:
 My plug-in successfully modified the signup location adding the parameter
 needed.
 1. wp-login.php redirects to the filtered url
 2. wp-signup.php checks if it !is_main_site(), but till 3.4 not passing
 any parameter to is_main_site was basically always returning true, and
 !true always false.

 Behaviour in WordPress 3.5 MS and later:
 1. wp-login.php redirects to the filtered url
 2. wp-signup.php checks if it !is_main_site(), this returns true (it is
 not) and then passes and then redirect once more using network_site_url
 3. network_site_url seems removing any parameter added, jeopardizing my
 filter added earlier.

 The exact patch that changed this (correctly probably) is this one:
 http://core.trac.wordpress.org/attachment/ticket/22090/22090.diff

 My question is: now, how can have my added parameter not filtered out?

 thank you
 Marco

--

Comment:

 Can you provide a link to your plugin or the part which hooks into
 wp_signup_location?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23443#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software