[wp-trac] [WordPress Trac] #22896: Prevent plugins from overriding jQuery in the admin

WordPress Trac noreply at wordpress.org
Mon Feb 11 05:50:46 UTC 2013


#22896: Prevent plugins from overriding jQuery in the admin
------------------------------------+-----------------------
 Reporter:  nacin                   |       Owner:
     Type:  enhancement             |      Status:  reopened
 Priority:  normal                  |   Milestone:  3.6
Component:  External Libraries      |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by adamsilverstein):

 Replying to [comment:56 nacin]:
 > Replying to [comment:54 adamsilverstein]:
 > > i thought since this ticket was so long and patched it deserved a new
 ticket, but you know better.
 >
 > Not a problem. This is ticket has a very high signal-to-noise ratio, and
 isn't terribly long. Contrast with #23119... and #11817.
 >
 > > i added a unit test :) please review, thanks.
 >
 > Great. Some points:
 >  * No need for setUp or tearDown if you have no code there. Parent
 methods will be called.
 >  * Use `@ticket 23417` in a properly indented doc block to label the
 test as linked to this ticket. You can then run it with `phpunit --group
 23417`.
 >  * We call these dependencies, and there are existing tests. This method
 probably go in Test_Dependencies_jQuery (tests/dependencies/jquery.php).

 i reworked
 [http://core.trac.wordpress.org/attachment/ticket/22896/22896.unittest.diff
 as a diff], does that look better?

 i'm trying to write unit tests for every bug i encounter, they seem super
 useful and fairly straightforward to me. it would be great if there was a
 'has-unit-test' tag available i could use to mark tests for review!

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22896#comment:58>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list