[wp-trac] [WordPress Trac] #23396: Revision team proposed changes patches for testing

[WordPress Trac]

#23396: Revision team proposed changes patches for testing
------------------------------------+--------------------
 Reporter:  adamsilverstein         |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  3.6
Component:  Revisions               |     Version:  3.5.1
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+--------------------

Comment (by adamsilverstein):

 I am uploading several mockup patches for testing. these patches implement
 (approximately) the [http://make.wordpress.org/core/2013/02/05/revision-
 update-25/#comment-7943 recent mockups] provided by @karmatosed. Notes
 below.

 Most of the designs in this go round are similar, with just slight layout
 modifications.

 [http://f.cl.ly/items/1G2V1z251I0144291X0g/version1.png Version 1.]
 version-1.diff
 Lots of changes -
  * from the edit post page click a revision takes you right to the
 comparison view - comparing the current revision to the selected revision.
  * also shown is a revision comment (but we don't have a place to enter or
 edit these).

 on the diff screen
  *added and removed lines in the upper right. currently these numbers are
 actually calculated lower down on the page and moved up on the page using
 CSS. I did this for expediency, but we pay want to re-work.
  * comments are shown at the top of the pages
  * clicking two compare checkboxes initiates a diff between the two, the
 oldest revision title is always shows on the left
  * note the left column always displays removed lines, the right column
 displays added lines, both columns display lines that are unchanged, i
 think this is confusing
  * the 'compare revisions' button is gone, and there is '''no way''' to
 actually restore a revision - we need to resolve that
  * the revision diff is stored, computed and shown on three fields -
 post_title, post_content and post_excerpt. before this diff the field name
 was shown down the left hand column
 ([http://f.cl.ly/items/2j1d2e0Y3J211o0E343L/oldversion1.png like this]).
 this diff removes that column entirely.
 looks like this: [[Image(http://f.cl.ly/items/2t0C0B1A1z2x3q1O3x35/diff-
 version1.png)]]

 [http://f.cl.ly/items/2v2B1k0R3m1e2d2z3q22/version2.png Version 2.]
 version-2.diff
  * dropped the top noted
  * header layout changed
  * did not implement mockup gray background on revision list, stuck with
 standard alternating color background
  * added back compare revisions button for accessibility, needs thought
 looks like this: [[Image(http://f.cl.ly/items/3O2E0I030q250P2h392u/diff-
 version-2.png)]]

 [http://f.cl.ly/items/12080t1B3t2H3o0y2O1D/version3.png Version 3.]
 version-3.diff
  *small layout changes (i see now that i missed one layout changed, but
 got it in version 4 below)
 looks like this: [[Image(http://f.cl.ly/items/22440w0M1k212i2Q1U2O/diff-
 version-3.png)]]

 [http://f.cl.ly/items/2Z2G2R1u0F1Q0n0e3v1J/version4.png Version 4.]
 version-4.diff
  * change text colors, add line-through; instead of red/green background
 to indicate changes
  * +/- old/new along middle spine
  looks like this: [[Image(http://f.cl.ly/items/261m1P1q202s3h2B3k1R/diff-
 version-4.png)]]

 [http://f.cl.ly/items/12080i2z2V3n3z3H1u2q/version5.png Version 5.]
 version-5.diff
  *some layout changes
  *repeats lines added/removed count above each column
  looks like this: [[Image(http://f.cl.ly/items/0j3j0Y1n2b3H1Z1f1N0E/diff-
 version-5.png)]]

 also, i added a few additional variations,
 * diff 6
  * starts based on version 3, and adds responsive design
  * for screen sizes 980px wide or larger, displays the revisions list to
 the left of the diff view
  * removes the comments column from the revision list
  * pictured below at three width screens, middle size needs attention
 widescreen
 [[Image(http://f.cl.ly/items/073a2y1R1A023w1J1J1W/diff-version-6-3
 %2Bresponsive-wide.png)]]
 small screen
 [[Image(http://f.cl.ly/items/1l3H423Z2G2L0e1n0P2f/diff-version-6-3
 %2Bresponsive-small-screen.png)]]
 midsize screen
 [[Image(http://f.cl.ly/items/2r3D252B0o3u1I0i240a/diff-version-6-3
 %2Bresponsive-midsize.png)]]

 * diff 7
  * displays diff in combined view with removed and added lines combined, a
 narrow column down the right side indicated sections that are removed or
 added. i think this view shows the changes between the two revisions most
 clearly.
  * there is still no link to 'restore revision', perhaps a button at the
 upper right? or back in revision list.
 [[Image(http://f.cl.ly/items/263U1K2b0L43163f0C0M/diff-version-7.png)]]

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23396#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software