[wp-trac] [WordPress Trac] #14979: custom background view shows cropped image and not original upload

[WordPress Trac]

#14979: custom background view shows cropped image and not original upload
--------------------------------------------------+--------------------
 Reporter:  obvio                                 |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  3.6
Component:  Appearance                            |     Version:  3.0.1
 Severity:  normal                                |  Resolution:
 Keywords:  dev-feedback has-patch needs-testing  |
--------------------------------------------------+--------------------
Changes (by cdog):

 * cc: catalin.dogaru@… (added)
 * keywords:  needs-patch dev-feedback => dev-feedback has-patch needs-
               testing


Comment:

 Agreed. Even this is the intended behavior I found it confusing. It would
 be better to display the original image instead of its thumbnail.

 Also found that saving a custom background from the theme customizer
 produces unexpected output on the Custom Background screen.

 Steps to reproduce:

 1. Upload a custom background from Appearance > Background and save.
 Everything looks as expected (attachment:custom-background.png, top).
 2. Open the theme customizer (Appearance > Themes > Customize), edit
 anything and save.
 3. Return to Appearance > Background. Now the original image is displayed
 instead of its thumbnail and the preview pane is very tall (attachment
 :custom-background.png, bottom).

 This is caused by the [http://core.trac.wordpress.org/browser/trunk/wp-
 includes/class-wp-customize-setting.php#L437 update()] callback from
 `WP_Customize_Background_Image_Settings` class which removes the thumbnail
 theme mod.

 attachment:14979.diff uses the original image instead of its thumbnail and
 sets the height of the preview pane properly when a custom background is
 set. Also adds control over the background size as shown in
 attachment:14979.png.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14979#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software