[wp-trac] [WordPress Trac] #23311: Enable internationalization in PHPMailer
WordPress Trac
noreply at wordpress.org
Mon Feb 4 05:08:05 UTC 2013
#23311: Enable internationalization in PHPMailer
-------------------------+------------------
Reporter: iandunn | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.6
Component: I18N | Version: 3.5
Severity: minor | Resolution:
Keywords: has-patch |
-------------------------+------------------
Comment (by iandunn):
Replying to [comment:4 nacin]:
> What we can do instead is add every string in PHPMailer::SetLanguage to
the WordPress POT file, so it may be translated like any other string in
WordPress.
>
> Then, we can set $phpmailer->language directly, with our own strings.
>
> As $phpmailer->language is protected, it would probably make the most
sense to actually extend PHPMailer and create a WP_PHPMailer class.
>
> Unit tests should then test that we are not missing any strings in
WP_PHPMailer that are present in a potential future version of PHPMailer,
by confirming that the keys returned by PHPMailer::GetTranslations() line
up.
>
That's done in 23311.2.diff and 23311.2-unit-tests.diff.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/23311#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list